TheeMahn wrote:The above bug maybe true in edgy, maybe even feisty... in hardy it uses long integers and the reason I had to re-write it (as can be seen above), BTW usplash-dev was replaced with libusplash-dev... I am sorry I do not have time to write a GTK (GUI based app at this time, my basket is way too full)
I have to disagree with you. Here's revision 1 of usplash-theme.h from the svn/bzr and it has always used short integers for palette index values. I looked at your source for 1.9 you posted above, and couldn't find where you changed anything to a long integer. Am I missing something here or did you rewrite the low-end usplash code?
Rev 1 of usplash-theme.hI did notice that you've used some of the paletting/appending concepts we've whipped up but they still aren't perfect. I opened up the various resolutions in GIMP and checked, and they all have a different number of colors and do not share the same palette across all images. When converting, appending, and cropping the images use the -depth 8 and -colors 256 options also. Sorry, but I figured this out after I posted my last code.
examples:
- Code: Select all
convert usplash/usplash.png -resize "800X600!" -quality 100 -strip -colors 256 -depth 8 usplash/tmp_800_600.png
- Code: Select all
convert usplash/tmp_600_400.png usplash/tmp_640_480.png usplash/tmp_800_600.png usplash/tmp_1024_768.png usplash/tmp_1152_864.png usplash/tmp_1280_1024.png usplash/tmp_1600_1200.png usplash/tmp_1920_1440.png usplash/throbber_back.png usplash/throbber_fore.png -append +dither -colors 256 -depth 8 usplash/pal.png
- Code: Select all
convert usplash/pal.png -crop 800x600+0+880! -depth 8 usplash/usplash_800_600.png
Since your splash images are grayscale colors, you wont really notice any problems, but if you used an image with lots of reds/greens/blues/etc, you would notice inconsistencies with the colors when it comes to text and such, since each different resolution would have a different color at index 251 for example, and or it's very possible that index 251 just doesn't exist in that resolution.
Back to the Hex color bug. Trust me, I just tested your usplash for 1.9 and it's borked. Don't use hex values, use short ints(0-255), as an 8-bit image cannot have more than 256 colors. To prove it to you, copy your usplash to the /usr/lib/usplash directory and then test with this script. I can guarantee you that about halfway through the scrolling verbose text, it will start randomly changing colors.
Usage: sudo /bin/bash usplashmagick-test
usplashmagick-test
- Code: Select all
#!/bin/bash
#
# Copyright (c) 2008 Reconstructor Team, TheeMahn
# If it wasn't for TheeMahn's hard work, this wouldn't exist.
# Originally Written by
# Eisenberger Tama's <u-foka at freemail dot hu>
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
echo "Testing newly created usplash..."
usplash -c -x 800 -y 600 $1 &
sleep 1
usplash_write "VERBOSE true"
usplash_write "TIMEOUT 0"
usplash_write "TEXT Testing usplash theme..."
sleep 1
usplash_write "SUCCESS [OK]"
usplash_write "TEXT Progress 20%..."
usplash_write "PROGRESS 20"
sleep 1
usplash_write "SUCCESS [OK]"
usplash_write "TEXT Progress 40%..."
usplash_write "PROGRESS 40"
sleep 1
usplash_write "SUCCESS [OK]"
usplash_write "TEXT Progress 60%..."
usplash_write "PROGRESS 60"
sleep 1
usplash_write "SUCCESS [OK]"
usplash_write "TEXT Progress 80%..."
usplash_write "PROGRESS 80"
sleep 1
usplash_write "SUCCESS [OK]"
usplash_write "TEXT Progress 100%..."
usplash_write "PROGRESS 100"
sleep 1
usplash_write "SUCCESS [OK]"
usplash_write "TEXT Sending Failed Message..."
sleep 1
usplash_write "FAILURE [FAILED]"
usplash_write "TEXT Pulsating..."
sleep 1
usplash_write "SUCCESS [OK]"
usplash_write "PULSATE"
sleep 10
usplash_write "SUCCESS [OK]"
sleep 2
usplash_write "QUIT"
echo "Did you see the Usplash?"
Ignore the fact that [FAILED] wont print out fully, thats just because your .status_width = 35,
Please don't let another Ultimate Usplash be borked upon release
As far as a GUI/GTK usplash maker, don't worry about it too much, I'm planning on doing a GTK/python for usplashmagick, and I can almost guarantee you are going to be the first person I want testing it
...I just need to find time myself to get it done.
Posted: Sun May 25, 2008 9:30 pm
