red_team316 wrote:TheeMahn wrote:The above bug maybe true in edgy, maybe even feisty... in hardy it uses long integers and the reason I had to re-write it (as can be seen above), BTW usplash-dev was replaced with libusplash-dev... I am sorry I do not have time to write a GTK (GUI based app at this time, my basket is way too full)
I have to disagree with you. Here's revision 1 of usplash-theme.h from the svn/bzr and it has always used short integers for palette index values. I looked at your source for 1.9 you posted above, and couldn't find where you changed anything to a long integer. Am I missing something here or did you rewrite the low-end usplash code?
Rev 1 of usplash-theme.h
I did notice that you've used some of the paletting/appending concepts we've whipped up but they still aren't perfect. I opened up the various resolutions in GIMP and checked, and they all have a different number of colors and do not share the same palette across all images. When converting, appending, and cropping the images use the -depth 8 and -colors 256 options also. Sorry, but I figured this out after I posted my last code.
examples:
- Code: Select all
convert usplash/usplash.png -resize "800X600!" -quality 100 -strip -colors 256 -depth 8 usplash/tmp_800_600.png
- Code: Select all
convert usplash/tmp_600_400.png usplash/tmp_640_480.png usplash/tmp_800_600.png usplash/tmp_1024_768.png usplash/tmp_1152_864.png usplash/tmp_1280_1024.png usplash/tmp_1600_1200.png usplash/tmp_1920_1440.png usplash/throbber_back.png usplash/throbber_fore.png -append +dither -colors 256 -depth 8 usplash/pal.png
- Code: Select all
convert usplash/pal.png -crop 800x600+0+880! -depth 8 usplash/usplash_800_600.png
Since your splash images are grayscale colors, you wont really notice any problems, but if you used an image with lots of reds/greens/blues/etc, you would notice inconsistencies with the colors when it comes to text and such, since each different resolution would have a different color at index 251 for example, and or it's very possible that index 251 just doesn't exist in that resolution.
Back to the Hex color bug. Trust me, I just tested your usplash for 1.9 and it's borked. Don't use hex values, use short ints(0-255), as an 8-bit image cannot have more than 256 colors. To prove it to you, copy your usplash to the /usr/lib/usplash directory and then test with this script. I can guarantee you that about halfway through the scrolling verbose text, it will start randomly changing colors.
Usage: sudo /bin/bash usplashmagick-test
usplashmagick-test
- Code: Select all
#!/bin/bash
#
# Copyright (c) 2008 Reconstructor Team, TheeMahn
# If it wasn't for TheeMahn's hard work, this wouldn't exist.
# Originally Written by
# Eisenberger Tama's <u-foka at freemail dot hu>
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
echo "Testing newly created usplash..."
usplash -c -x 800 -y 600 $1 &
sleep 1
usplash_write "VERBOSE true"
usplash_write "TIMEOUT 0"
usplash_write "TEXT Testing usplash theme..."
sleep 1
usplash_write "SUCCESS [OK]"
usplash_write "TEXT Progress 20%..."
usplash_write "PROGRESS 20"
sleep 1
usplash_write "SUCCESS [OK]"
usplash_write "TEXT Progress 40%..."
usplash_write "PROGRESS 40"
sleep 1
usplash_write "SUCCESS [OK]"
usplash_write "TEXT Progress 60%..."
usplash_write "PROGRESS 60"
sleep 1
usplash_write "SUCCESS [OK]"
usplash_write "TEXT Progress 80%..."
usplash_write "PROGRESS 80"
sleep 1
usplash_write "SUCCESS [OK]"
usplash_write "TEXT Progress 100%..."
usplash_write "PROGRESS 100"
sleep 1
usplash_write "SUCCESS [OK]"
usplash_write "TEXT Sending Failed Message..."
sleep 1
usplash_write "FAILURE [FAILED]"
usplash_write "TEXT Pulsating..."
sleep 1
usplash_write "SUCCESS [OK]"
usplash_write "PULSATE"
sleep 10
usplash_write "SUCCESS [OK]"
sleep 2
usplash_write "QUIT"
echo "Did you see the Usplash?"
Ignore the fact that [FAILED] wont print out fully, thats just because your .status_width = 35,
Please don't let another Ultimate Usplash be borked upon release
As far as a GUI/GTK usplash maker, don't worry about it too much, I'm planning on doing a GTK/python for usplashmagick, and I can almost guarantee you are going to be the first person I want testing it ...I just need to find time myself to get it done.
I have not had the chance to test your theory, but I have seen the colors change when I remove quiet from grub, so I would say you are probably correct... using vga=868 (widescreen) in my grub also works but doesn't it pushes my progress bar to the right but oddly enough my text is centered and maintains color of a dark brown. The wallpaper or what ever you want to call it is also pressed off the left side of my screen.
Looking further into this I discovered, even though my monitor supports widescreen resolutions up to 1680 x 1050, my xorg log reports that my video card does not support a frame buffered resolution greater then 1280 X 1024 and reports resolutions greater then that as a "future enhancement".
The usplashes as long as textmode is not used in my opinion are flawless. We strive for perfection given time I will look into this. Any software you wish for me to test I'm down with it. It would be easy to write a python based app to call os.popen for all image conversions, probably not that difficult to hook it to stdout and get progress... After I get done building Ultimate Edition 1.9 X86, I may have some free time too look into it further, maybe write software to get it done, I just hate messing with glade...
9 1/2 hrs to upload Ultimate Edition 1.9 x86, I have some time
I am going to make it in my spare time, so it will be a lengthy process...
Using what I learned about making debs I could make it create a deb, that will set it as the "default usplash" if the user so selects, all I would have to do is take the filename create a folder with the following structure
Filename>DEBIAN>control
control file would be somewhat generic
FileName>DEBIAN>postinst
- Code: Select all
#!/bin/sh
set -e
case "$1" in
configure)
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/chrometext-theme.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/chrome-theme.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/ultimate-edition-1.9.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/dark-splash.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/metal-theme.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/Sleek_Dragon_Usplash_Splash-01.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/Sleek_Dragon_Usplash_Splash-02.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/ubuntugris-theme.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/Ultimate.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/usplash-fingerprint-remix.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/usplash-theme-beans_16_9.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/usplash-theme-beans_4_3.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/usplash-theme-comptus.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/usplash-theme-fingerprint.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/usplash-theme-fingerprint-alpha.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/usplash-theme-ulitmate.so 10
update-alternatives --install /usr/lib/usplash/usplash-artwork.so usplash-artwork.so /usr/lib/usplash/usplash-theme-uue1.6.so 10
update-alternatives --set usplash-artwork.so /usr/lib/usplash/ultimate-edition-1.9.so
update-initramfs -u
;;
esac
As Ultimate Edition Themes package does as of -4 (unreleased currently)
Filename>usr>lib>usplash>filename.so
dpkg --build Filename
If the user were to uninstall the deb could have it generate a uninstall routine as once again Ultimate Edition theme pack now has:
- Code: Select all
#! /bin/sh
set -e
case “$1″ in
remove)
update-alternatives -remove usplash-artwork.so /usr/lib/usplash/ultimate-edition-1.9.so
update-initramfs -u
;;
esac
this drops the Ultimate Edition 1.9 usplash set during installation.
the end user would have a deb they could install and will automatically set the usplash as the current usplash, no hassles no startupmanager etc. I have big plans for it... Preview dragable progress bar, perhaps later custom progress bars, x and y coordinates set by the user dragging a bar, 0 knowledge required by the end user. at first I am going to stick with zenity as it compiles etc. Eventually full blown python.
Wow, now that I think about it I can leave my terminal.py portion of ultamatix to let them see conversion / compilation etc. and use the progress bar at the top to show overall progress... x amount of steps divided by current step...
It will be a long time before we have a release believe that.
TheeMahn